Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Deprecate span toContext() and updateWithContext() #10030

Merged
merged 3 commits into from
Jan 3, 2024
Merged

feat(core): Deprecate span toContext() and updateWithContext() #10030

merged 3 commits into from
Jan 3, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 3, 2024

These APIs are not really used, and are not compatible with OpenTelemetry. So let's deprecate them for removal in v8.

Unless somebody knows a reason why we still need something like this?

@mydea mydea self-assigned this Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.96 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.4 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.09 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.24 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 204.14 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 94.03 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.21 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.78 KB (0%)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.43 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.06 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

@mydea
feat(core): Deprecate span toContext() and updateWithContext()
ef18cc7 
These APIs are not really used, and are not compatible with OpenTelemetry. So let's deprecate them for removal in v8.
@mydea
add migration docs
adf2a76
@mydea
fix linting
f0c5553
@mydea mydea force-pushed the fn/deprecate-span-toContext branch from cd839ba to f0c5553 Compare January 3, 2024 09:48
lforst
lforst approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React native uses these but I think it is fine for us to deprecate them bc there is a migration path.

@mydea mydea merged commit 16c4dbe into develop Jan 3, 2024
95 checks passed
@mydea mydea deleted the fn/deprecate-span-toContext branch January 3, 2024 10:27
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@mydea @anonrig
feat(core): Deprecate span toContext() and updateWithContext() (#…
0fda0f3 
…10030)

These APIs are not really used, and are not compatible with
OpenTelemetry. So let's deprecate them for removal in v8.

Unless somebody knows a reason why we still need something like this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @lforst @Lms24